Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alters ASay chat color back to the old MSay color #4151

Merged
merged 17 commits into from
Aug 12, 2023
Merged

Alters ASay chat color back to the old MSay color #4151

merged 17 commits into from
Aug 12, 2023

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Aug 10, 2023 •
edited by github-actions bot
Loading

Changing Asay back to the Msay color that many were used to for a very long time.

Explain why it's good for the game

Because this color doesn't blend in with other major chat colors (such as dsay, and others), and it reminds us of simpler times.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
admin: Adjustment of ASay color
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Admin Make things harder for admins labels Aug 10, 2023
@blackdragonTOW blackdragonTOW changed the title Update chat-dark.scss Alters ASay chat color back to the old MSay color Aug 10, 2023
@blackdragonTOW
Update chat-light.scss
2f03a38 
fine, lightmode can come too
@blackdragonTOW
Update chat-light.scss
0486281
@blackdragonTOW
Update chat-dark.scss
599feca
@blackdragonTOW
Update chat-dark.scss
22a62bc 
this fucking code style and capitalization even when color HEX codes are involved...
@blackdragonTOW
Update chat-light.scss
e50c2aa 
big A, small A what's the diff honestly
realforest2001
realforest2001 requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@realforest2001 realforest2001 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently making tickets appear brown too, please can you make it so tickets remain purple so they're easier to identify.

It's also not using both colours, only the headminsay colour is being used.

@realforest2001 realforest2001 marked this pull request as draft August 10, 2023 12:40
@Time-Warper Time-Warper mentioned this pull request Aug 10, 2023
Open
3 tasks
@blackdragonTOW
Copy link
Contributor Author

blackdragonTOW commented Aug 10, 2023 •
edited
Loading

Removed changes to headminsay colors as those do not alter the asay color of hosts in asay.

Additionally, as it stands before this change, ASay is purple. Tickets are purple. There hasn't been confusion about those colors being the same, so tickets and asay being the same color is also fine. Tickets are a function of ASay and move through that channel, thus the coloring.
To make tickets and asay separate we would have to add a great deal that would be outside the scope of this color change PR and would need to be atomized with another PR.

@blackdragonTOW
Copy link
Contributor Author

What if we did.........this....

@blackdragonTOW
Copy link
Contributor Author

Okay, this should achieve the following goals:
Headmins have different colors in ASay
ASay chat messages are the OG mod colors
Ahelps are still purple
ASay and AHelps are now distinct colors.

@blackdragonTOW blackdragonTOW marked this pull request as ready for review August 10, 2023 21:31
realforest2001
realforest2001 approved these changes Aug 10, 2023
View reviewed changes
code/modules/admin/tabs/admin_tab.dm Outdated Show resolved Hide resolved
harryob
harryob requested changes Aug 11, 2023
View reviewed changes
code/modules/admin/tabs/admin_tab.dm Outdated Show resolved Hide resolved
This was referenced Aug 11, 2023
Open
Open
@harryob harryob added this pull request to the merge queue Aug 12, 2023
Merged via the queue into cmss13-devs:master with commit 5d2305b Aug 12, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Aug 12, 2023
@cm13-github
Automatic changelog for PR #4151 [ci skip]
408e570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realforest2001 realforest2001 realforest2001 approved these changes

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
Admin Make things harder for admins UI deletes nanoui/html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackdragonTOW @realforest2001 @harryob